Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: simplification de la logique des champs listes #10807

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

LeSim
Copy link
Member

@LeSim LeSim commented Sep 17, 2024

ce lit commit par commit.

  • retire la logique des options disabled car ce code n'est plus utilisée et la pr Technique: nettoyage des options ignorées des types de champ drop_down_list #10780 a nettoyé les valeurs en base
  • retire le wrapper drop_down_list_options pour ne garder que l'attribut drop_down_options wrappé
  • inline parse_drop_down_list_value dans drop_down_list_value
  • inline drop_down_options? par drop_down_options.any? et retire l'indirection champ.options = champ.drop_down_options
  • homogénise l'utilisation de la methode render? dans les composants linked_drop_down et multiple_drop_down au lieu d un if dans la vue.
  • retire la première valeur '' que l'on mettait dans les listes et qu'on retirait après avant de les afficher

@LeSim LeSim force-pushed the slow_drop_down_cleaning branch from 95e97b3 to 612c11d Compare September 17, 2024 09:53
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (38ced21) to head (d3667bb).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
app/graphql/types/champ_descriptor_type.rb 0.00% 1 Missing ⚠️
app/models/champs/multiple_drop_down_list_champ.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10807      +/-   ##
==========================================
- Coverage   84.64%   84.62%   -0.02%     
==========================================
  Files        1131     1131              
  Lines       25072    25060      -12     
  Branches     4683     4681       -2     
==========================================
- Hits        21221    21208      -13     
- Misses       3851     3852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeSim LeSim force-pushed the slow_drop_down_cleaning branch 5 times, most recently from a8342ad to df42b99 Compare September 17, 2024 16:07
@LeSim LeSim force-pushed the slow_drop_down_cleaning branch from df42b99 to bc40b85 Compare September 18, 2024 08:08
@LeSim LeSim force-pushed the slow_drop_down_cleaning branch from bc40b85 to d3667bb Compare September 18, 2024 08:26
@LeSim LeSim added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit d32124d Sep 18, 2024
18 checks passed
@LeSim LeSim deleted the slow_drop_down_cleaning branch September 18, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants