Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ usager : correctif pour télécharger un dossier expiré #10667

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Jul 30, 2024

@colinux colinux added the bug label Jul 30, 2024
Copy link

what-the-diff bot commented Jul 30, 2024

PR Summary

  • Expansion of dossier_scope method in user dossier controller
    The dossier_scope method within the user dossier controller has been expanded with extra conditions. These changes allow the method to perform additional checks when the action_name is either set as 'extend_conservation_and_restore' or 'show', specifically when requesting a PDF format.

  • Additional Testing Scenarios in users' list of dossiers
    A new testing context has been added tailored for the situation 'when user downloads PDF of expired'. Alongside, a new scenario has also been introduced to test the generation of PDF when a user downloads a dossier.

@colinux colinux enabled auto-merge July 30, 2024 12:12
@colinux colinux added this pull request to the merge queue Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (bced38e) to head (e467be1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10667   +/-   ##
=======================================
  Coverage   80.20%   80.20%           
=======================================
  Files        1241     1241           
  Lines       26408    26408           
  Branches     4734     4734           
=======================================
  Hits        21181    21181           
  Misses       5227     5227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into demarches-simplifiees:main with commit a41f03e Jul 30, 2024
18 checks passed
@colinux colinux deleted the fix-dossier-expire-download branch July 30, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: A Communiquer
Development

Successfully merging this pull request may close these issues.

2 participants