Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech : fix migration with execute #10655

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Jul 26, 2024

No description provided.

Copy link

what-the-diff bot commented Jul 26, 2024

PR Summary

  • Safety Assured Update in Migration Method
    The method that guides the system in updating the database, located under 'AddDossierFolderColumnToExportTemplate', now includes a fail-safe block when executing certain database commands. This ensures the database will not be harmed in case of an unexpected error.

  • Addition of 'dossier_folder' and 'export_pdf' Columns in Database Table
    The database table 'export_templates' now includes two new columns: 'dossier_folder' and 'export_pdf'. Both are designed to store complex data, and will not have any initial values. They are also set up such that they must contain data (cannot be empty) in all future entries.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (12c174f) to head (96489e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10655   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files        1238     1238           
  Lines       26330    26330           
  Branches     4719     4719           
=======================================
  Hits        21109    21109           
  Misses       5221     5221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeSim LeSim added this pull request to the merge queue Jul 26, 2024
Merged via the queue into demarches-simplifiees:main with commit 11208aa Jul 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants