Skip to content

Commit

Permalink
Do not raise exception when Avis is not valid, just fix the data
Browse files Browse the repository at this point in the history
  • Loading branch information
mmagn committed Nov 26, 2024
1 parent 7932085 commit 5a0eca5
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def process(avis)
expert: expert
)

avis.update!(experts_procedure: correct_experts_procedure)
avis.update_column(:experts_procedure_id, correct_experts_procedure.id)
end
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,25 @@ module Maintenance
expect(avis.experts_procedure).to eq(correct_experts_procedure)
end
end

context "when the avis has an invalid question_answer" do
let(:avis) do
create(:avis,
dossier: dossier,
expert: expert,
experts_procedure: wrong_experts_procedure,
question_label: "Some question",
question_answer: nil)
end

it "fixes the experts_procedure association without validation errors" do
expect(avis).not_to be_valid
expect { process }.not_to raise_error

avis.reload
expect(avis.experts_procedure.procedure_id).to eq(procedure2.id)
end
end
end
end
end

0 comments on commit 5a0eca5

Please sign in to comment.