ERC1155 Compatibility #1238
Open
ERC1155 Compatibility #1238
+770
−434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
Sean329,
cashd and
sentilesdal
as code owners
Pull Request Test Coverage Report for Build 13083371547Details
💛 - Coveralls |
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Sean329
reviewed
Feb 2, 2025
| address _to, | ||
| uint256[] calldata _ids, | ||
| uint256[] calldata _amounts, | ||
| bytes memory _data |
There was a problem hiding this comment.
Why the 2 lines above can be calldata but this line is using memory?
I saw OZ is doing all 3 lines calldata here: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/828dbc357cd7975c0a31d919f6d4dcf7ef2dc427/contracts/token/ERC1155/IERC1155.sol#L121
| revert IHyperdrive.BatchInputLengthMismatch(); | ||
| } | ||
|
|
||
| // Call internal transfer for each asset. | ||
| for (uint256 i = 0; i < ids.length; i++) { | ||
| _transferFrom(ids[i], from, to, values[i], msg.sender); | ||
| for (uint256 i = 0; i < _ids.length; i++) { |
There was a problem hiding this comment.
nit: it should be a gas saver to read the _ids.length once and save it to a local uint length(on the stack, minimal gas) than repeatedly reading the _ids.length thru the loop (3 gas each time)?
| bytes calldata | ||
| ) external view returns (bytes4) { | ||
| // If the sender is the right Hyperdrive contract, we accept the transfer. | ||
| if (msg.sender == hyperdrive) { |
There was a problem hiding this comment.
I think at this time, the hyperdrive is still the dummy address 0x1 instead of the real address?
Sean329
reviewed
Feb 2, 2025
| ) external view returns (bytes4) { | ||
| // If the sender is the right Hyperdrive contract, we accept the batch | ||
| // transfer. | ||
| if (msg.sender == hyperdrive) { |
Sean329
reviewed
Feb 2, 2025
|
|
||
| // Load the balances. | ||
| uint256[] memory batchBalances = new uint256[](_accounts.length); | ||
| for (uint256 i = 0; i < _accounts.length; ++i) { |
There was a problem hiding this comment.
nit: same here for the gas related comment -- https://github.com/delvtech/hyperdrive/pull/1238/files#r1938433041
Sean329
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes Hyperdrive fully ERC1155 compatible. To do this, we added
safeTransferFrom,safeBatchTransferFrom, andbalanceOfBatch. To ensure that our contracts remain code size limit, we also had to removetransferFromandbatchTransferFrom.