Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aerodrome LP Integration for Base #1193

Merged
merged 19 commits into from
Oct 29, 2024
Merged

Aerodrome LP Integration for Base #1193

merged 19 commits into from
Oct 29, 2024

Conversation

sentilesdal
Copy link
Contributor

@sentilesdal sentilesdal commented Oct 18, 2024 •
edited
Loading

This PR adds the Aerodrome LP Hyperdrive instance and deployers. This instance wraps the AERO-USDC LP Token on Base and deposits the token into the corresponding Gauge contract to earn AERO rewards. There are a couple things of note here:

  • The Gauge contract does not return a share token, so we set the vault address to zero.
  • To claim rewards we need to call getReward(address account) on the Gauge contract. An external function getReward() was added to AerodromeLpHyperdrive that claims to the Hyperdrive contract. Anyone can call this. Follows normal sweep operation after this.

@sentilesdal sentilesdal force-pushed the matt/aerodrome-base branch 3 times, most recently from 208c677 to 8ed6a55 Compare October 24, 2024 17:17
@sentilesdal sentilesdal changed the title WIP - Aerodrome Integration Aerodrome LP Integration for Base Oct 24, 2024
@sentilesdal sentilesdal force-pushed the matt/aerodrome-base branch 2 times, most recently from 799f58c to dafedcd Compare October 25, 2024 15:17
@coveralls
Copy link
Collaborator

coveralls commented Oct 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11566492636

Details

  • 51 of 61 (83.61%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 88.785%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/instances/aerodrome-lp/AerodromeLpTarget0.sol 1 2 50.0%
contracts/src/instances/aerodrome-lp/AerodromeLpBase.sol 13 15 86.67%
contracts/src/deployers/aerodrome-lp/AerodromeLpHyperdriveDeployerCoordinator.sol 15 22 68.18%
Totals Coverage Status
Change from base Build 11564400163: -0.1%
Covered Lines: 2763
Relevant Lines: 3112
💛 - Coveralls

jalextowle
jalextowle approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this! LGTM once the remaining nits are resolved

@sentilesdal sentilesdal enabled auto-merge October 29, 2024 03:02
@sentilesdal sentilesdal added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 8b44be2 Oct 29, 2024
33 of 36 checks passed
@sentilesdal sentilesdal deleted the matt/aerodrome-base branch October 29, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazyGio MazyGio MazyGio left review comments

@jalextowle jalextowle jalextowle approved these changes

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

@mcclurejt mcclurejt Awaiting requested review from mcclurejt

@cashd cashd Awaiting requested review from cashd

@dpaiton dpaiton Awaiting requested review from dpaiton

@slundqui slundqui Awaiting requested review from slundqui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sentilesdal @coveralls @jalextowle @MazyGio