Moonwell EURC #1189
Merged
Moonwell EURC #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd,
sentilesdal,
dpaiton and
slundqui
as code owners
jalextowle
force-pushed
the
jalextowle/integration/moonwell-eurc
branch
from
786e0d8 to
e00a140
Compare
jrhea
requested changes
Oct 16, 2024
jalextowle
force-pushed
the
jalextowle/integration/moonwell-eurc
branch
from
9cc7a79 to
8352d17
Compare
jrhea
approved these changes
Oct 16, 2024
jalextowle
force-pushed
the
jalextowle/integration/moonwell-eurc
branch
from
01e6363 to
3212480
Compare
Closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Pull Request Test Coverage Report for Build 11563543464Details
💛 - Coveralls |
jalextowle
force-pushed
the
jalextowle/integration/moonwell-eurc
branch
from
ca44549 to
b8d55ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds testing for the Moonwell EURC yield source. Unlike most of our other yield sources, this yield source has a base decimals of
6and vault share decimals of18. Furthermore, the vault share price is quite low at around ~1e6. With this in mind, some of the tolerances are significantly larger than what we'd expect to see with other yield sources.