Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staked Well #1187

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Staked Well #1187

merged 5 commits into from
Oct 9, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR adds a Staked Well integration.

jrhea
jrhea reviewed Oct 9, 2024
View reviewed changes
test/utils/InstanceTest.sol Outdated Show resolved Hide resolved
jrhea
jrhea approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@jrhea jrhea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a couple of nits

mcclurejt
mcclurejt approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/src/instances/stk-well/StkWellHyperdrive.sol Show resolved Hide resolved
@jalextowle jalextowle force-pushed the jalextowle/integration/staked-well branch from 6097265 to 2ad2a9f Compare October 9, 2024 16:43
@jalextowle jalextowle changed the base branch from main to jalextowle/integration/moonwell October 9, 2024 16:44
Base automatically changed from jalextowle/integration/moonwell to main October 9, 2024 17:07
@jalextowle jalextowle force-pushed the jalextowle/integration/staked-well branch from 2ad2a9f to 12b59f9 Compare October 9, 2024 17:46
@jalextowle jalextowle enabled auto-merge October 9, 2024 17:46
@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11260288821

Details

  • 42 of 51 (82.35%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 88.861%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/src/deployers/stk-well/StkWellHyperdriveDeployerCoordinator.sol 17 26 65.38%
Totals Coverage Status
Change from base Build 11259724679: -0.1%
Covered Lines: 2489
Relevant Lines: 2801
💛 - Coveralls

@jalextowle jalextowle added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 540732a Oct 9, 2024
30 of 34 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/staked-well branch October 9, 2024 18:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Hyperdrive Gas Benchmark

Benchmark suite Current: 12b59f9 Previous: e59377e Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 192930 gas 193318 gas -0.2007% ✅
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147821 gas 147742 gas 0.0535% 🚨
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 129841 gas 129824 gas 0.0131% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124780 gas 124721 gas 0.0473% 🚨
closeShort: max 277335 gas 277335 gas 0% 🟰
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355890 gas 355864 gas 0.0073% 🚨
initialize: max 424801 gas 424801 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173682 gas 173546 gas 0.0784% 🚨
openLong: max 339778 gas 339778 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 172584 gas 172301 gas 0.1642% 🚨
openShort: max 415044 gas 415078 gas -0.0082% ✅
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 75257 gas 74586 gas 0.8996% 🚨
redeemWithdrawalShares: max 311225 gas 311225 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 217334 gas 216004 gas 0.6157% 🚨
removeLiquidity: max 403261 gas 403671 gas -0.1016% ✅

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhea jrhea jrhea approved these changes

@mcclurejt mcclurejt mcclurejt approved these changes

@cashd cashd Awaiting requested review from cashd

@sentilesdal sentilesdal Awaiting requested review from sentilesdal sentilesdal is a code owner

@dpaiton dpaiton Awaiting requested review from dpaiton

@slundqui slundqui Awaiting requested review from slundqui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalextowle @coveralls @jrhea @mcclurejt