Uni v3 Zap #1179
Merged
Uni v3 Zap #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd,
sentilesdal,
dpaiton and
slundqui
as code owners
Pull Request Test Coverage Report for Build 11282077538Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
reviewed
Oct 10, 2024
jrhea
approved these changes
Oct 10, 2024
mcclurejt
approved these changes
Oct 10, 2024
jalextowle
added a commit
that referenced
this pull request
Oct 15, 2024
* forge install: v3-periphery v1.3.0 * Added a basic Uniswap v3 zap contract * Added a Uni v3 zap for `closeLong` and improved the zap for `openLong` * Added a zap for `addLiquidity` * Cleaned up the validation logic for Uni v3 zaps * Adds zaps for `removeLiquidity` and `redeemWithdrawalShares` * Added the remaining zaps * Started writing tests for `addLiquidityZap` * Updated the zap to use multi-hop routing * Wrote some more tests * Refactored the `addLiquidityZap` tests * Added tests for `openLongZap` * Added a full test suite for `openLongZap` * Broke out the zap tests and added test for `openShortZap` * Added support for zaps out starting with ETH * Added tests for `removeLiquidity` * Added tests for `redeemWithdrawalSharesZap` * Added tests for `redeemWithdrawalSharesZap` * Added tests for `closeLongZap` * Added tests for `closeShortZap` * Cleaned up the tests * Bump the version * Remaining cleanup * Fixed the UniV3Zap * Added wrapping tests * Some cleanup * Some cleanup * Addressed review feedback from @jrhea * Addressed remaining review feedback from @jrhea * Appeased the linter gods * Addressed review feedback from @mcclurejt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a zap contract that supports generalized swapping between assets using Uniswap V3. Each Hyperdrive trading or LP function has a direct anologue in the zap contract that exposes all of the parameters as well as a few extra parameters for things like the Uniswap swap object (
ISwapRouter.ExactInputParams) and special-case parameters to handle different edge-cases in the zap.Extensive tests were added that should test the different paths through these functions. Special care was taken to verify that ETH, WETH, and rebasing tokens are properly handled by the zap contract. Since Uniswap v3 doesn't really support ETH as a first-class citizen in all situations, there are several flows within the zap contract where ETH will be converted to WETH or vice-versa. For the most part, this is unopinionated and will support all use-cases, but in the case of zapping funds out of the zap, WETH will always be unwrapped into ETH before sending it to the user.
Some notable things to watch out for are:
openShortZap's lack of precision compared to the other flows. This is unavoidable because of the way that Hyperdrive'sopenShortlogic functions.