Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbETH Integration on Base #1167

Merged
merged 5 commits into from
Sep 10, 2024
Merged

cbETH Integration on Base #1167

merged 5 commits into from
Sep 10, 2024

Conversation

jalextowle
Copy link
Contributor

Description

This PR adds tests and deployment tools for the cbETH integration on Base. This integration makes use of the ChainlinkHyperdrive instance, and as part of this PR, I refactored the Chainlink instance tests to make it easier to add more chainlink integrations.

Copy link
Contributor

@mcclurejt mcclurejt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM all comments are nits

tasks/deploy/lib/constants.ts Outdated Show resolved Hide resolved
test/utils/BaseTest.sol Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10798684544

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.674%

Totals Coverage Status
Change from base Build 10784491063: 0.0%
Covered Lines: 2362
Relevant Lines: 2634

💛 - Coveralls

Copy link

github-actions bot commented Sep 10, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: 9fcaa52 Previous: 63abf9c Deviation Status
addLiquidity: min 33812 gas 33812 gas 0% 🟰
addLiquidity: avg 193402 gas 193121 gas 0.1455% 🚨
addLiquidity: max 474677 gas 474677 gas 0% 🟰
checkpoint: min 40338 gas 40338 gas 0% 🟰
checkpoint: avg 147732 gas 147718 gas 0.0095% 🚨
checkpoint: max 259386 gas 259386 gas 0% 🟰
closeLong: min 31390 gas 31390 gas 0% 🟰
closeLong: avg 130161 gas 129927 gas 0.1801% 🚨
closeLong: max 2539405 gas 2539405 gas 0% 🟰
closeShort: min 31378 gas 31378 gas 0% 🟰
closeShort: avg 124990 gas 124768 gas 0.1779% 🚨
closeShort: max 277335 gas 277335 gas 0% 🟰
initialize: min 31356 gas 31356 gas 0% 🟰
initialize: avg 355910 gas 355907 gas 0.0008% 🚨
initialize: max 424801 gas 424801 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 173629 gas 173560 gas 0.0398% 🚨
openLong: max 339778 gas 339778 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 173081 gas 172606 gas 0.2752% 🚨
openShort: max 415003 gas 415155 gas -0.0366%
redeemWithdrawalShares: min 31240 gas 31240 gas 0% 🟰
redeemWithdrawalShares: avg 74994 gas 74536 gas 0.6145% 🚨
redeemWithdrawalShares: max 311225 gas 311225 gas 0% 🟰
removeLiquidity: min 31246 gas 31246 gas 0% 🟰
removeLiquidity: avg 216214 gas 216598 gas -0.1773%
removeLiquidity: max 403671 gas 403671 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@jalextowle jalextowle added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 252867b Sep 10, 2024
33 checks passed
@jalextowle jalextowle deleted the jalextowle/integration/cbeth branch September 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants