-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fee overhaul & targeted long fix #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
336007b
to
2aeca1b
Compare
29135ed
to
426fb54
Compare
426fb54
to
2d40100
Compare
dpaiton
commented
May 14, 2024
dpaiton
commented
May 14, 2024
dpaiton
commented
May 14, 2024
dpaiton
commented
May 14, 2024
027124b
to
b832625
Compare
dpaiton
commented
May 14, 2024
b832625
to
06e27a5
Compare
06e27a5
to
f2abae8
Compare
jrhea
reviewed
May 14, 2024
jrhea
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ryangoree
reviewed
May 14, 2024
This was referenced May 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the result of an audit of the fee functions. The following changes were made (one commit per bullet):
open_short_curve_fee
#97. We realized that the bug actually lies in the solidity test utils. This has been fixed so I reverted the rounding behavior to match.c(x)
at some times andcurve_fee
at other times, or using repeat symbols for different equations.maybe_curve_fee
arg to gov fee calculations to fix Avoid redundant calculations forcalculate_close_short_flat_plus_curve
#43 and reduce computation.internal/HyperdriveBase.sol
calculate_targeted_long
where the gov fee (and derivative) was not converted to shares. I updated my overleaf doc, the docstrings, and the code itself.Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.
covering the full input space?
ensure that Rust matches Solidity?