add calculate_bonds_given_effective_shares_and_rate
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
requested review from
jalextowle,
jrhea,
mcclurejt,
sentilesdal,
ryangoree,
slundqui and
wakamex
as code owners
slundqui
reviewed
May 10, 2024
dpaiton
force-pushed
the
dpaiton/calc-bonds
branch
from
0cfec1c to
c77085f
Compare
dpaiton
force-pushed
the
dpaiton/calc-bonds
branch
from
c77085f to
801a810
Compare
slundqui
reviewed
May 10, 2024
dpaiton
force-pushed
the
dpaiton/calc-bonds
branch
from
9a18f47 to
d9fae38
Compare
dpaiton
force-pushed
the
dpaiton/calc-bonds
branch
from
d9fae38 to
8e21d70
Compare
slundqui
approved these changes
May 11, 2024
dpaiton
changed the title
calculate_bonds_given_effective_shares_and_rate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#75 removed a function that was used by
agent0. This PR brings the function back under a different, more accurate name.I also had to write a new test for it since the function does not exist in solidity.
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.
covering the full input space?
ensure that Rust matches Solidity?