Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add addLiquidity variants #76

Merged
merged 3 commits into from
May 5, 2024
Merged

add addLiquidity variants #76

merged 3 commits into from
May 5, 2024

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented May 3, 2024

Description

This PR adds the delta and state variants to addLiquidity

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.

  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?
    • If matching Solidity behavior, are there differential fuzz tests that
      ensure that Rust matches Solidity?

crates/hyperdrive-math/src/lp.rs Outdated Show resolved Hide resolved
crates/hyperdrive-math/src/lp.rs Outdated Show resolved Hide resolved
crates/hyperdrive-math/src/lp.rs Outdated Show resolved Hide resolved
@jrhea jrhea force-pushed the add_liquidity_variants branch from 2ba3270 to 7ae497b Compare May 3, 2024 21:35
Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jrhea jrhea force-pushed the add_liquidity_variants branch from c503ad4 to 94edd5c Compare May 5, 2024 00:24
@jrhea jrhea enabled auto-merge (squash) May 5, 2024 00:25
@jrhea jrhea merged commit 443b9d6 into main May 5, 2024
13 checks passed
@jrhea jrhea deleted the add_liquidity_variants branch May 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants