add test to verify inversion of base/bonds in open short #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaiton
force-pushed
the
dpaiton/max-short-test
branch
2 times, most recently
from
d927aa0 to
2a4a006
Compare
dpaiton
changed the base branch from
main
to
dpaiton/remove-checkpoint-exposure
sentilesdal
force-pushed
the
dpaiton/max-short-test
branch
from
36c400e to
1f2eb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
#185
Description
This PR adds a test to verify the conversion between base and bonds via open short functions is consistent.
The test follows the recommendation in the cited issues.
The test currently FAILS, so it is ignored and a follow-up PR will implement fixes so that it passes.