Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add txn retries to agent.rs, deploy.rs #204

Merged
merged 8 commits into from
Dec 14, 2024
Merged

Conversation

dpaiton
Copy link
Contributor

@dpaiton dpaiton commented Dec 3, 2024

The latest anvil release is ocassionally failing when fetching logs from agent transactions, causing many CI tests to fail. This PR adds a retry loop to the log fetching code to fix the problem.

A couple of tests failed due to tolerances. I'm not sure what has changed to cause this, maybe we're running different seeds now?

  • short::open::tests::fuzz_calculate_implied_rate
    • increased tolerance from 1e12 to 1e19.
  • lp::remove::tests::fuzz_sol_calculate_remove_liquidity (renamed from fuzz_test_calculate_remove_liquidity)
    • increased tolerance from 0 to 1e9 in comparison rust vs solidity test

long::max::tests::test_calculate_max_long also failed with Error: Contract call reverted with data: 0xbb55fd27 once out of ~10 test runs. I was not able to reproduce it, so I am leaving it alone for now.

@dpaiton dpaiton changed the title add txn retries to agent.rs add txn retries to agent.rs, deploy.rs Dec 3, 2024
@dpaiton dpaiton marked this pull request as ready for review December 3, 2024 22:29
@dpaiton dpaiton requested a review from jalextowle December 6, 2024 21:42
@dpaiton dpaiton merged commit 252e35c into main Dec 14, 2024
8 checks passed
@dpaiton dpaiton deleted the dpaiton/add-txn-retries branch December 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants