-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distribute_excess_idle
#17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48e666b
to
f4dcf79
Compare
85ad5d5
to
6782e2b
Compare
3c7b7ef
to
756b866
Compare
distribute_excess_idle
distribute_excess_idle
dd933bd
to
72a0da7
Compare
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
dpaiton
reviewed
May 14, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
jalextowle
reviewed
May 15, 2024
49c5b07
to
20a2601
Compare
dpaiton
approved these changes
May 22, 2024
20a2601
to
5b8467c
Compare
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
jalextowle
reviewed
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. Just a few more comments.
6ec8427
to
4c0535f
Compare
4c0535f
to
ae9d765
Compare
this was mislabelled, added the unsafe version too.
ae9d765
to
a52be1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
Description
Adds
distribute_excess_idle
and all the helpers needed for it. Here's the full list:calculate_distribute_excess_idle
calculate_distribute_excess_idle_share_proceeds
calculate_distribute_express_idle_withdrawal_shares_redeemed
should_short_circuit_distribute_excess_idle_share_proceeds
calculate_distribute_excess_idle_share_proceeds_net_long_edge_case
calculate_max_share_reserves_delta
explicit tests were added:
fuzz_test_calculate_distribute_excess_idle
fuzz_test_calculate_distribute_excess_idle_withdrawal_shares_redeemed
fuzz_test_should_short_circuit_distribute_excess_idle_share_proceeds
fuzz_test_calculate_distribute_excess_idle_share_proceeds_net_long_edge_case
Everything should be covered by the first test, but the others helped me debug along the way.
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.
covering the full input space?
ensure that Rust matches Solidity?