-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix calculate_spot_price_after_short
and add open short deltas & preview
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6bda3c
to
edb40b2
Compare
40f1eb2
to
da553b7
Compare
da553b7
to
917622f
Compare
calculate_spot_price_after_short
calculate_spot_price_after_short
and add calculate_open_short_share_reserves_delta
calculate_spot_price_after_short
and add calculate_open_short_share_reserves_delta
calculate_spot_price_after_short
and add open short deltas & preview
3097673
to
50d4049
Compare
sentilesdal
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good! I think we should get in the habit of adding /// comments at the top of functions to give clues what they do, helps reviewers at least.
e9b2985
to
db3ba2b
Compare
027f5e4
to
246ea72
Compare
246ea72
to
9a6ec40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issues
No issue
Description
calculate_spot_price_after_short
did not correctly compute the share deltas when abase_amount
was not given. This PR adds a test to demonstrate this as well as a fix.Part of the process also required adding
calculate_open_short_deltas
and a corresponding test.Since I was most of the way there, I also added a
preview_open_short
that returns a mutated state after the reserve deltas have been applied.Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed.
covering the full input space?
ensure that Rust matches Solidity?