Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs & fix CI #1

Merged
merged 5 commits into from
Apr 26, 2024
Merged

update docs & fix CI #1

merged 5 commits into from
Apr 26, 2024

Conversation

dpaiton
Copy link
Contributor

@dpaiton dpaiton commented Apr 25, 2024 •
edited
Loading

Resolved Issues

No issues

Description

  • add some minor docstring fixes & moves code to test a PR in the new repo
  • fix CI to run lint & tests

@dpaiton dpaiton changed the title update docstrings update docs Apr 25, 2024
@dpaiton dpaiton force-pushed the dpaiton/test-commit branch 4 times, most recently from 1cfbde0 to b126f9b Compare April 25, 2024 20:01
@dpaiton dpaiton changed the title update docs update docs & fix CI Apr 25, 2024
@dpaiton dpaiton force-pushed the dpaiton/test-commit branch 12 times, most recently from 1080cea to f53a220 Compare April 26, 2024 00:35
@dpaiton dpaiton force-pushed the dpaiton/test-commit branch from f53a220 to 87e363d Compare April 26, 2024 00:38
jalextowle
jalextowle approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should do a mkdirp

ryangoree
ryangoree approved these changes Apr 26, 2024
View reviewed changes
.github/workflows/rust_lint.yml Outdated Show resolved Hide resolved
.github/workflows/rust_lint.yml Show resolved Hide resolved
@dpaiton dpaiton force-pushed the dpaiton/test-commit branch 2 times, most recently from 00c5ee5 to 64faf28 Compare April 26, 2024 18:39
@dpaiton dpaiton force-pushed the dpaiton/test-commit branch from 64faf28 to 8002f70 Compare April 26, 2024 18:43
@dpaiton dpaiton enabled auto-merge (squash) April 26, 2024 19:09
@dpaiton dpaiton merged commit 3a9b2fa into main Apr 26, 2024
4 checks passed
@dpaiton dpaiton deleted the dpaiton/test-commit branch April 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalextowle jalextowle jalextowle approved these changes

@ryangoree ryangoree ryangoree approved these changes

@jrhea jrhea Awaiting requested review from jrhea

@mcclurejt mcclurejt Awaiting requested review from mcclurejt

@sentilesdal sentilesdal Awaiting requested review from sentilesdal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpaiton @ryangoree @jalextowle