Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts closed lp table #460

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Converts closed lp table #460

merged 4 commits into from
Oct 23, 2023

Conversation

jackburrus
Copy link
Contributor

@jackburrus jackburrus commented Oct 20, 2023

This PR converts the closed lp table to use react table.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-fixed-borrow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:51pm
hyperdrive-monorepo-hyperdrive-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:51pm
hyperdrive-sdk-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:51pm
trading-competition ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:51pm

return (
<tr
key={row.id}
className="daisy-hover h-16 cursor-pointer grid-cols-4 items-center"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hover needed on the closed tables

{tableInstance.getHeaderGroups().map((headerGroup) => (
<tr key={headerGroup.id}>
{headerGroup.headers.map((header) => (
<th className="sticky top-0 bg-white" key={header.id}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we say bg-base-100 instead (the daisy equivalent) does that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants