Trading Volume 24h #247
Trading Volume 24h #247
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| export async function getTradingVolume( | ||
| hyperdriveAddress: Address, | ||
| publicClient: PublicClient<Transport, Chain>, | ||
| currentBlockNumber: bigint, | ||
| ): Promise<string> { |
There was a problem hiding this comment.
Let's make this an object argument with an interface to be consistent with the other hyperdrive/core functions.
| export function getTradingVolumeQuery({ | ||
| hyperdriveAddress, | ||
| publicClient, | ||
| currentBlockNumber, | ||
| }: { | ||
| hyperdriveAddress: Address; | ||
| publicClient: PublicClient<Transport, Chain>; | ||
| currentBlockNumber: bigint; | ||
| }): QueryObserverOptions<Awaited<ReturnType<typeof getTradingVolume>>> { | ||
| return { | ||
| queryKey: ["tradingVolume", { hyperdriveAddress, publicClient }], | ||
| queryFn: () => | ||
| getTradingVolume(hyperdriveAddress, publicClient, currentBlockNumber), | ||
| enabled: !!hyperdriveAddress && !!publicClient && !!currentBlockNumber, |
There was a problem hiding this comment.
Currently, enabled here isn't necessary because it's checking the truthiness of values that are required to be truthy. But, once you add the interface for the getTradingVolume function, you can replace the inline options type for the argument with Partial<GetTradingVolumeOptions> which will make all options optional.
| const totalVolume = | ||
| calculateTotalAmount(longEvents) + calculateTotalAmount(shortEvents); | ||
|
|
||
| return totalVolume.toString(); |
There was a problem hiding this comment.
Let's return both the bigint and formatted value to be consistent with the other hyperdrive/core functions (https://github.com/delvtech/hyperdrive-monorepo/blob/main/packages/hyperdrive/src/amm/longs/getLongPrice.ts#L55-L58)
| ): number { | ||
| return events | ||
| .map((event) => parseInt(formatUnits(event.eventData.bondAmount, 18))) | ||
| .reduce((a, b) => a + b, 0); |
There was a problem hiding this comment.
| ): number { | |
| return events | |
| .map((event) => parseInt(formatUnits(event.eventData.bondAmount, 18))) | |
| .reduce((a, b) => a + b, 0); | |
| ): bigint { | |
| return events | |
| .reduce((a, b) => a.eventData.bondAmount + b.eventData.bondAmount, 0n); |
| iconUrl: string; | ||
| }) { | ||
| return ( | ||
| <span className="flex flex-row items-center justify-start font-semibold"> | ||
| <img className="mr-1 h-4" src={iconUrl} /> | ||
| {parseInt(liquidity).toLocaleString()} | ||
| {parseInt(value).toLocaleString()} |
There was a problem hiding this comment.
We have a helper function for this called formatBalance
This PR implements the 24h trading volume using the events on openLong and openShort.
