Buttons default to normal case #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackburrus
reviewed
Jul 13, 2023
| @@ -86,11 +85,8 @@ export function CloseLongForm({ | |||
| )} | |||
|
|
|||
| {account ? ( | |||
| <Button | |||
| disabled={!closeLong || isPendingWalletAction} | |||
There was a problem hiding this comment.
Do we still need this disabled logic? Now isPendingWalletAction is unused above
There was a problem hiding this comment.
ah good catch, yes we do!
jackburrus
reviewed
Jul 13, 2023
| @@ -29,7 +29,7 @@ export function OpenShortModalButton({ | |||
| {/* Using a div styled as a button here just as a visual cue. Don't | |||
| use a real button here since the Well is interactive already, and | |||
| doing so would create invalid dom nesting of buttons. */} | |||
| <div className="daisy-btn-accent daisy-btn-sm daisy-btn mt-2 justify-between gap-0 normal-case"> | |||
| <div className="daisy-btn-accent daisy-btn-sm daisy-btn mt-2 justify-between gap-0"> | |||
There was a problem hiding this comment.
If we are going to be using this class string in a lot of places, it might make sense to place it into a tailwind component.
https://tailwindcss.com/docs/reusing-styles
There was a problem hiding this comment.
Yeah I could see this whole "Well w/ Call-To-Action inside it" becoming it's own component that we re-use.
Something like this eventually:
<CallToActionWell
variant="primary" // "primary" | "secondary" | "accent"
icon={...}
header="Open Short"
description="..."
action={<button>{...}</button>}
onClick={...}
/>
jackburrus
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons with all-caps labels are hard to read, especially when including abbreviations, like
ADD LP.