Fix bug causing incorrect Short balance to show #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackburrus
reviewed
Jul 11, 2023
| }: GetPoolConfigOptions): Promise< | ||
| ContractFunctionResult<typeof HyperdriveABI, "getPoolConfig"> | ||
| > { | ||
| return await publicClient.readContract({ |
There was a problem hiding this comment.
What happens if readContract fails here? Maybe add some error handling.
jackburrus
reviewed
Jul 11, 2023
| }: GetPoolInfoOptions): Promise< | ||
| ContractFunctionResult<typeof HyperdriveABI, "getPoolInfo"> | ||
| > { | ||
| return publicClient.readContract({ |
There was a problem hiding this comment.
Same as above, although this one is not being awaited.
jackburrus
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only logical change here is a one-liner in the final commit. The rest is mechanical stuff, moving things into their own files (cleaning up the TODO above them), and renaming things (
getCurrentFixedAPRQuery)