New tabs for Longs, Shorts, LP #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DannyDelott
force-pushed
the
danny-display-open-shorts
branch
from
fc8c168 to
ac02f83
Compare
ryangoree
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Looking at this more, the tabs feel disconnected and far away over on the right. What if we switched the top tabs off to the right to Open/Close, then justify the sub tabs centered and use the Boxed tabs for Longs/Shorts/LP to make them feel closer to the table and easier to find?
| } | ||
| case "LP": | ||
| /* TODO: Wire this up */ | ||
| return <Well>Under construction</Well>; |
There was a problem hiding this comment.
Lol "Under construction" reminds me of the gifs we used on websites in the early 2000s
docs/CodingStyle.md
Outdated
Comment on lines
36
to
37
| - Squash and merge PRs. | ||
| - Rebase to avoid merge commits in PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glassclass for hover instead of more bespoke styling)