Deprecate DSRHyperdriveABI, Fix Router #202
Conversation
DannyDelott
commented
Jul 3, 2023
DannyDelott
commented
- From pairing with @jalextowle, we'll get a consolidated hyperdrive abi soon. For now, this PR deprecates the dsrHyperdrive abi.
- Other minor cleanups
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <p className="font-light "> | ||
| Maximize your exposure to the DAI Savings Rate (DSR) | ||
| </p> | ||
| <div className="daisy-btn-accent daisy-btn-sm daisy-btn mt-2 justify-between gap-0 normal-case"> |
There was a problem hiding this comment.
Good eye, I need to add a comment here. Using a div since using button would created nested buttons in the markup. The parent element is a button (Well set to interactive), and so we just want this here as a visual cue.
| queryKey: [ | ||
| "@hyperdrive/core", | ||
| "closed-longs", | ||
| { hyperdriveAddress, account }, | ||
| ], |
There was a problem hiding this comment.
What's the thinking behind adding the package name to the key?
There was a problem hiding this comment.
I think it's good practice for queries packages to namespace themselves, since consumers call these with their own queryClient. The namespace is helpful for debugging and avoiding possible collisions with the app's queries. It also gives apps a quick way to invalidate all the queries without needing to get too specific with keys.
DannyDelott
changed the title
DannyDelott
changed the title
