Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up the RewardsTooltip to new rewards from appconfig #1727

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

DannyDelott
Copy link
Contributor

Rewards in the UI are now being read from the appconfig.rewards object for open short and add liquidity.

Once this lands, I'll:

  • clean up the remaining deprecated callers (mostly useYieldSourceRate)
  • remove any unused appconfig selectors and hooks
  • remove any deprecated appconfig fields on HyperdriveConfig and YieldSourceConfig to complete the migration to the new rewards system

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: f55a7f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:30pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 6:30pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 6:30pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 6:30pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 6:30pm
testnet-v1 ⬜️ Ignored (Inspect) Jan 13, 2025 6:30pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 6:30pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2025 6:30pm

@@ -27,7 +27,7 @@ export function VariableApyCta({
chainId: hyperdrive.chainId,
hyperdriveAddress: hyperdrive.address,
});
const { rewards } = useRewards(hyperdrive);
const { rewards } = useOpenShortRewards({ hyperdriveConfig: hyperdrive });
Copy link
Contributor

@jackburrus jackburrus Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the lpapystat the rewards variable is renamed. I think we either rename to "shortRewards" or "liquidityRewards" or just keep it at 'rewards' across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants