Cleanup portfolio components #1658
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
| <a | ||
| className="daisy-link" | ||
| href="https://docs.hyperdrive.box/hyperdrive-overview/position-types/longs-fixed-rates" | ||
| rel="noopener noreferrer" | ||
| target="_blank" | ||
| > | ||
| documentation | ||
| </a>{" "} |
There was a problem hiding this comment.
We should use the ExternalLink component here for analytics. If you wanna tack it now, that'd be nice, but I'd also understand if this is just a mechanical PR and we want to tackle this in a later PR.
There was a problem hiding this comment.
Can we just move this up to the parent dir instead of wrapping single files in dirs with the same name?
There was a problem hiding this comment.
Here and throughout where it's done.
| /* | ||
| This regex removes the term from the hyperdrive name since it's already shown in the table. | ||
| It matches: | ||
| - \d{1,3}: 1 to 3 digits | ||
| - d: Followed by the letter 'd' | ||
| */ hyperdrive.name.replace(/\d{1,3}d/, "") |
There was a problem hiding this comment.
Appreciate the explanation in the comment! For auto-generated explanations and additional context, you can use regex101.com to create a minimal example and add a link here. Here's an example: https://regex101.com/r/PLmbXb/1
hyperdrive-frontend/crates/fixed-point-wasm/scripts/build.ts
Lines 52 to 56 in ab61a96
DannyDelott
force-pushed
the
danny-cleanup-portfolio-components
branch
from
ea89efd to
a251ded
Compare
Lots of duplicate code to DRY up in preparation for adding the Rewards tab content.