Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Deprecated Components #1640

Merged
merged 11 commits into from
Nov 9, 2024
Merged

Cleanup Deprecated Components #1640

merged 11 commits into from
Nov 9, 2024

Conversation

jackburrus
Copy link
Contributor

The vast majority of this PR is renaming the components we appended "Two" or "Old" to their newer versions and deleting the old components.

Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: 1161c81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 4:16pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 4:16pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm
testnet-v1 ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm
trading-competition ⬜️ Ignored (Inspect) Nov 9, 2024 4:16pm

@@ -165,7 +165,7 @@ export function RedeemWithdrawalSharesForm({
) : undefined
}
value={amount ?? ""}
stat={
bottomRightElement={
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only component I had not updated to the new design. I was able to just swap out the TokenInput and the form looks fine. I created an issue for converting the full form soon:
#1641

@jackburrus jackburrus merged commit 15ba03d into main Nov 9, 2024
14 checks passed
@jackburrus jackburrus deleted the cleanup-twos branch November 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants