chore: upgrade Electron from 32 to 34 #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/upgrade-electron-to-34
branch
from
b257d14 to
575485b
Compare
nicodh
approved these changes
Jan 31, 2025
Is this a big deal? Because we can upgrade to the latest 32, and it would still resolve the referenced issue. |
Well that would give us some weeks (maybe month) and then we have to upgrade anyway. So let's upgrade to 34 now |
FYI breaking changes: - https://www.electronjs.org/blog/electron-33-0#breaking-changes - https://www.electronjs.org/blog/electron-34-0#breaking-changes Closes #3416. Appears to work after some basic testing.
WofWca
force-pushed
the
wofwca/upgrade-electron-to-34
branch
from
575485b to
f4c04ff
Compare
|
Why did this close #3416? |
|
Electron fixed it electron/electron#45472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI breaking changes. Nothing much appears to apply to us, except perhaps macOS. Please re-check:
Closes #3416.
Appears to work after some basic testing.