Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove disabled composer reason, now composer is just always hidden when chat.canSend is false #3791

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

Simon-Laux
Copy link
Member

closes #3790

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, functionality wise.

simon and me just had a chat and agreed that it is better to remove it completely for now than to show misleading (as in #3790) or wrong texts (currently mailinglists say we do not support writing)
in theory, the latter could have been changed easily, but we just never came to it, so, it is also a maintenance problem.

after the next release, we can think over if we want an api that brings the "reason bar" back for situations where the info-messages are not fully sufficient - these are only read-only-mailinglists and maybe group-left (the latter is somehow clear by info-message). one-to-ones will get detailed info-messages by chatmail/core#5475

EDIT: for read-only-mailinglists, an easy and less-cluttering alternative is to show them in the title bar as "Read-Only Mailinglist" or "Mailinglist (read only)" so (it is better to not show the "disabled bar" permanently during normal usage)
this is the place where we also otherwise show "info" of the chat, eg. for mailinglists on desktop, the address is shown there already. broadcast-lists, which are very similar to read-only-mailinglists, are annouced there as well.
(maybe a minor, but still: by that, we also have less complexity in the message-input-area on all platforms; also, no new API is needed in core)

however, these are all cornercases, it is fine to remove it completely now. thanks for fixing

@Simon-Laux Simon-Laux merged commit 3e2f634 into master Apr 26, 2024
5 of 7 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3790 branch April 26, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message when following an invitelink is misleading
2 participants