Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fetch chat twice #1262

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Don't fetch chat twice #1262

merged 2 commits into from
Dec 19, 2019

Conversation

nicodh
Copy link
Member

@nicodh nicodh commented Dec 17, 2019

resolves #1260

@nicodh nicodh requested review from Jikstra and Simon-Laux December 17, 2019 20:59
Simon-Laux
Simon-Laux requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't resolve the issue it makes it worse, not only is the chat still open, now I can also still see the messages of the last account

@nicodh
Copy link
Member Author

nicodh commented Dec 18, 2019

Interesting - so we have completely different behaviour.
I will investigate further...

@Jikstra Jikstra merged commit 38f59eb into master Dec 19, 2019
@Jikstra
Copy link
Contributor

Jikstra commented Dec 19, 2019

@Simon-Laux can't reproduce your issue, works as expected for me. Besides this, selecting a chat is now also fast again :)

@Jikstra Jikstra deleted the fix_1260 branch December 19, 2019 10:46
@nicodh
Copy link
Member Author

nicodh commented Dec 19, 2019

I think my second issue fixed the bug mentioned in this ticket...

@Simon-Laux
Copy link
Member

👍 can confirm master works now nicely again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simon-Laux Simon-Laux Simon-Laux requested changes

@Jikstra Jikstra Awaiting requested review from Jikstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: chatstore is not correctly cleared when account is switched?
3 participants
@nicodh @Jikstra @Simon-Laux