Update and integrate appstream file #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
force-pushed
the
appstream
branch
10 times, most recently
from
11b051f to
4a48ac6
Compare
The appstream/appdata file is required for linux destop appliciations and is not packaging-format specific so makes sense to include upstream. - Update existing appdata file. - Add .desktop file since this is referred to by the appdata. - Update the travis config to test this appdata and .desktop files making sure they remain correct. We have to add linux back to the job matrix for this, but we only want to publish a binary release using electron-builder on OSX. - Skip running the integration test on Linux, it doesn't want to work and I'm not in the business of fixing that and life is too short. Fixes #729.
|
I experimented with multiple jobs instead of the default matrix as well, but the main downside is there is no data shared between jobs so i stuck with the not overly nice main matrix thing instead. The ugly part of that is how i select things which are only for one platform, but it works. |
ralphtheninja
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.
Update existing appdata file.
Add .desktop file since this is referred to by the appdata.
Update the travis config to test this appdata and .desktop files
making sure they remain correct. We have to add linux back to the
job matrix for this, but we only want to publish a binary release
using electron-builder on OSX.