Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship appstream metadata #729

Closed
flub opened this issue Mar 16, 2019 · 4 comments
Closed

Ship appstream metadata #729

flub opened this issue Mar 16, 2019 · 4 comments
Assignees
Labels
packaging Packaging/distribution related issues

Comments

@flub
Copy link
Member

flub commented Mar 16, 2019

This is currently added in the flatpak repo, but is not specific to flatpak really so should probably lie here instead.

@flub flub self-assigned this Mar 16, 2019
@flub flub added the packaging Packaging/distribution related issues label Mar 16, 2019
@Jikstra
Copy link
Contributor

Jikstra commented Mar 17, 2019

I guess it's about moving this file over to this repo?
https://github.com/flathub/chat.delta.desktop/blob/master/chat.delta.desktop.appdata.xml

@flub
Copy link
Member Author

flub commented Mar 17, 2019

Yes, but turns out it already lives in static/! anyway, i'm updating it and configuring travis to validate it (the latter taking up all the time). It needs to be updated with every release sadly so i also updated the readme with instructions. Lastly it turns out it also refers to the .desktop so that needs to moe al well.

@muelli
Copy link
Contributor

muelli commented Mar 17, 2019

and it needs to be shipped with binary releases, in case you produce any. That's what electron-userland/electron-builder#1993 is about IIUC.

@muelli
Copy link
Contributor

muelli commented Mar 17, 2019

I guess it's about moving this file over to this repo?

and it's about updating it to reflect a new release.

flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
flub pushed a commit that referenced this issue Mar 17, 2019
The appstream/appdata file is required for linux destop appliciations
and is not packaging-format specific so makes sense to include
upstream.

- Update existing appdata file.

- Add .desktop file since this is referred to by the appdata.

- Update the travis config to test this appdata and .desktop files
  making sure they remain correct.  We have to add linux back to the
  job matrix for this, but we only want to publish a binary release
  using electron-builder on OSX.

Fixes #729.
@flub flub closed this as completed in 5f1804b Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Packaging/distribution related issues
Projects
None yet
Development

No branches or pull requests

3 participants