Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-emoji get bigger when jumbomoji (big emoji) enabled #1989

Closed
salixh5 opened this issue Nov 27, 2020 · 2 comments · Fixed by #1998
Closed

Non-emoji get bigger when jumbomoji (big emoji) enabled #1989

salixh5 opened this issue Nov 27, 2020 · 2 comments · Fixed by #1998
Assignees
@Simon-Laux
Labels
bug Something isn't working

Comments

@salixh5
Copy link

salixh5 commented Nov 27, 2020

deltachat-desktop/src/renderer/components/message/MessageBody.tsx

Line 18 in 69fe2c6

const emojifiedText = trim(text.replace(/:[\w\d_\-+]*:/g, replaceColons))

I'm no regex expert but I suspect this will recognize messages even when they don't only consist of emoji. See example:

スクリーンショット 2020-11-27 15 05 43
@Simon-Laux Simon-Laux added the bug Something isn't working label Nov 27, 2020
@Simon-Laux
Copy link
Member

not the right regex / code line but thanks for the bug report.

@Simon-Laux
Copy link
Member

Simon-Laux commented Dec 1, 2020 •
edited
Loading

@jeifour which DeltaChat version are you using?

Edit: I reproduced it, looks like it sees Kana as emojis (is kana the right term? I have it from https://www.linguajunkie.com/japanese/japanese-alphabet)

@Simon-Laux Simon-Laux self-assigned this Dec 1, 2020
Simon-Laux added a commit that referenced this issue Dec 1, 2020
@Simon-Laux
reindroduce a real emoji regex
dd7c1fe 
(turns out that the regex that contains all emojis is better than the
one that I found online)
fixes #1989
@Simon-Laux Simon-Laux mentioned this issue Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simon-Laux Simon-Laux

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reindroduce a real emoji regex deltachat/deltachat-desktop
2 participants
@salixh5 @Simon-Laux