Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor]: Refactor GRPC API #292

Merged
merged 3 commits into from
Dec 20, 2019
Merged

[Refactor]: Refactor GRPC API #292

merged 3 commits into from
Dec 20, 2019

Conversation

adwaith007
Copy link
Contributor

Forgive me for the bad file names, I couldn't be more creative.

nimishagarwal76
nimishagarwal76 reviewed Dec 20, 2019
View reviewed changes
Copy link
Collaborator

@nimishagarwal76 nimishagarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserService.go contains stuff specific to user like GetPortfolio. So rather then having

  • GetNotifications
  • GetTransactions
  • GetLeaderboard

in Misc.go, we should place them in UserService.go

@adwaith007
Copy link
Contributor Author

@nimishagarwal76 review

@adwaith007 adwaith007 changed the title [Refactor]: Refactor ActionService [Refactor]: Refactor GRPC API Dec 20, 2019
@nimishagarwal76
Copy link
Collaborator

Pls sync with latest proto and frontend, I will merge then

@nimishagarwal76 nimishagarwal76 merged commit 208a0b1 into master Dec 20, 2019
@nimishagarwal76 nimishagarwal76 mentioned this pull request Jan 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishagarwal76 nimishagarwal76 nimishagarwal76 approved these changes

@akspi akspi Awaiting requested review from akspi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adwaith007 @nimishagarwal76