-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonWriter converts structured parsing error into plain string #2143
Labels
bug
Something isn't working
Comments
take |
abaerptc
added a commit
to abaerptc/delta-rs
that referenced
this issue
Jan 29, 2024
abaerptc
added a commit
to abaerptc/delta-rs
that referenced
this issue
Jan 29, 2024
rtyler
pushed a commit
that referenced
this issue
Jan 29, 2024
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this issue
Jan 30, 2024
ion-elgreco
pushed a commit
to ion-elgreco/delta-rs
that referenced
this issue
Jan 30, 2024
RobinLin666
pushed a commit
to RobinLin666/delta-rs
that referenced
this issue
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Delta-rs version:
0.16.5 and
main
branchBinding:
Rust
Environment:
Bug
What happened:
When parsing fails, JsonWriter converts
DeltaWriterError::DeltaTable(DeltaTableError::Arrow { source: ArrowError::JsonError(_) })
to aDeltaTableError::Generic(string)
. This makes it impossible to handle error cases in client code without parsing strings.What you expected to happen:
JsonWriter should return
DeltaTableError::Arrow{ source: ArrowError::JsonError(_) }
.How to reproduce it:
Add the following unit test in
json.rs
:More details:
The text was updated successfully, but these errors were encountered: