mkprof command clobbers item file with empty one when --skeleton flag not used

[ned2]

When not supplying the --skeleton flag, the mkprof will clobber the newly created item file containing the input items with an empty item file when it creates empty files for all tables.

I see the problem in main.mkprof, will try and submit a PR.

[goodmami]

Oops, I thought I'd tested that. Is this on the develop branch?

[ned2]

That was in version 0.6.2 from PyPy.

I just forked and was about to add the appropriate check to skip over the item file but ran into another problem on the ;latest develop branch:

Traceback (most recent call last):
  File "/home/nejl/.pyenv/versions/3.6.2/bin/delphin", line 11, in <module>
    load_entry_point('PyDelphin==0.6.3a0', 'console_scripts', 'delphin')()
  File "/home/nejl/.pyenv/versions/3.6.2/lib/python3.6/site-packages/delphin/main.py", line 169, in main
    command(args)
  File "/home/nejl/.pyenv/versions/3.6.2/lib/python3.6/site-packages/delphin/main.py", line 314, in mkprof
    for table in p.relations:
AttributeError: 'NoneType' object has no attribute 'relations'

Looks like p never gets assigned a profile, but that bit of code assumes it has. Might have to leave it with you at this point :)

[goodmami]

Please try checking out the develop branch and see if you can reproduce the problem. I touched those lines a bit recently and tested these things, I thought...

On Thu, Aug 31, 2017, 18:51 Ned Letcher ***@***.***> wrote: This was version 0.6.2 from PyPy. I just forked and was about to add the appropriate check to skip over the item file but ran into another problem: Traceback (most recent call last): File "/home/nejl/.pyenv/versions/3.6.2/bin/delphin", line 11, in <module> load_entry_point('PyDelphin==0.6.3a0', 'console_scripts', 'delphin')() File "/home/nejl/.pyenv/versions/3.6.2/lib/python3.6/site-packages/delphin/main.py", line 169, in main command(args) File "/home/nejl/.pyenv/versions/3.6.2/lib/python3.6/site-packages/delphin/main.py", line 314, in mkprof for table in p.relations: AttributeError: 'NoneType' object has no attribute 'relations' Looks like p never gets assigned a profile, but that bit of code assumes it has. Might have to leave it with you at this point :) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#125 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXLw6uZTf_gb-0U1nvLNkuRPRVGGv0eks5sd2MpgaJpZM4PJmqu> .

-- Michael Wayne Goodman

[ned2]

Can't reproduce the same problem because of the new exception. To reproduce that from the develop branch, this command line from the wiki does it for me:

$ echo -e "A dog barks.\n*Dog barks a." \
  | delphin mkprof \
      --relations ~/logon/lingo/lkb/src/tsdb/skeletons/english/Relations \
      newprof

[goodmami]

Oh sorry, I'm on my phone and didn't catch that your second attempt was on develop. Thanks for that; I'll take a look.

[ned2]

No worries :) As it happens I only actually need a skeleton but forgot to supply the flag, so it's not blocking any work for me right now.

[goodmami]

Can you pull and try again on develop? It seems to keep the item files for me.

This is maybe the shortest possible diff... just one character fixed the stacktrace :)

[ned2]

Success! No exception, and no clobbered item file. two issues fixed for the price of one character :)

[goodmami]

Great, thanks for confirming. I'll close the issue.