Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix t5 and mistral model load from config meta tensor bug #42

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

daisyden
Copy link

@daisyden daisyden commented Jan 4, 2024

Verified the performance and accuracy are the same as load from pretrain.

t5 acc

Task Version Metric Value Stderr
lambada_openai 0 ppl 4.1306 ± 0.1503
acc 0.7233 ± 0.0062
Task Version Metric Value Stderr
lambada_openai 0 ppl 4.1306 ± 0.1503
acc 0.7233 ± 0.0062

mistral acc

Task Version Metric Value Stderr
lambada_openai 0 ppl 3.1808 ± 0.0583
acc 0.7553 ± 0.0060
Task Version Metric Value Stderr
lambada_openai 0 ppl 3.1808 ± 0.0583
acc 0.7553 ± 0.0060

t5 perf on spr of diamond with 2 ranks single node:
Inference latency: 0.733 sec.

mistral:
InfInference latency: 1.416 sec.

Copy link
Owner

@delock delock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delock
Copy link
Owner

delock commented Jan 4, 2024

@daisyden can you also submit a PR to DeepSpeed upstream?

@delock delock merged commit 94873fe into delock:gma/run-opt-branch Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants