Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common CSM baseimage #108

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Use common CSM baseimage #108

merged 3 commits into from
Jan 24, 2025

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 22, 2025

Description

Use the common CSM base image for image builds. The benefit is that it will now be possible to build images on non RHEL VMs and as a non root user.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1691

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built images.
  • Started container from image and manually inspected the contents to validate that required programs are on the image.

anathoodell
anathoodell previously approved these changes Jan 22, 2025
@donatwork donatwork merged commit 06866e2 into main Jan 24, 2025
6 checks passed
@donatwork donatwork deleted the csm-base-image branch January 24, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants