Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set quota on target directory based on source actual size, not by its current consumed size #182

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Mar 29, 2023

Description

  • Set quota on target directory based on source actual size, not by its current consumed size.
  • Updated version from 2.6.0 to 2.6.1

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#753

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes (79.9%)
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested 10 PVs creation with no quotas and 20 PVs (5+5+10) with quotas enabled. When quotas is enabled, same quota gets set on both source and target directories.
  • Tested RG sync and failover actions. Verified data writes to source before failover and writes to target after failover.
    Captured log snippets.txt

Another round of test logs for QuotaScan workaround fix.
Test log - SyncIQ - QuotaScan.txt

@prablr79
Copy link
Collaborator

prablr79 commented Apr 5, 2023

@santhoshatdell can we get the checklist fully checked for this PR ?

@santhoshatdell santhoshatdell changed the base branch from release-2.6.0 to release-2.6.1 April 11, 2023 17:46
@santhoshatdell santhoshatdell marked this pull request as ready for review April 11, 2023 17:52
@santhoshatdell
Copy link
Contributor Author

@santhoshatdell can we get the checklist fully checked for this PR ?

Hi Prasanna,
I only work on replication related changes in this repo. When I do, I update replication related unit tests and try to keep up code coverage %. I cannot get the coverage to above 90%. We also have our e2e tests which we run to verify our fixes.

@santhoshatdell santhoshatdell merged commit bb73045 into release-2.6.1 Apr 13, 2023
@santhoshatdell santhoshatdell deleted the target-quota-fix branch April 13, 2023 18:32
santhoshatdell added a commit that referenced this pull request Apr 20, 2023
… current consumed size (#182) (#187)

Set quota on target directory based on source actual size, not by consumed size
Updated release version
shefali-malhotra pushed a commit that referenced this pull request Apr 26, 2023
… current consumed size (#182) (#187)

Set quota on target directory based on source actual size, not by consumed size
Updated release version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants