-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/release-creator #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/release-creator
shaynafinocchiaro
requested changes
Jan 27, 2025
@harishp8889, can you please list out all the test scenarios you tested here. |
…into feature/release-creator
francis-nijay
approved these changes
Jan 30, 2025
meggm
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shaynafinocchiaro
approved these changes
Jan 30, 2025
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
List the issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Tested by releasing csi-powermax (Both single and multi-image with reverseproxy):
https://github.com/harishp8889/test-csi-powermax/actions/runs/13030291528/job/36347842793
https://github.com/harishp8889/test-csi-powermax/actions/runs/13030724725/job/36349197644
https://github.com/harishp8889/test-csi-powermax/actions/runs/13036341291/job/36367624659
Tested by releasing go lib: https://github.com/harishp8889/test-gobrick-automation/actions/runs/13037011383/job/36369914475
Tested against cert-csi binary build as well: https://github.com/harishp8889/test-cert-csi/actions/runs/13047828897/job/36401427673
Tested against replication fork: https://github.com/harishp8889/test-csm-replication/actions/runs/13047967479/job/36401833223