Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify successful block volume expansion #88

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

rishabhatdell
Copy link
Contributor

Description

Previously, cert-csi did not validate whether block volumes were expanded successfully. This PR introduces a polling mechanism that waits for the FileSystemResizeSuccessful event, ensuring that block volume expansions are confirmed as successful.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1534

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran VolumeExapnsion Suite for block successfully
[root@master-1-XXXX ~]# ./cert-csi test expansion --sc powerstore-nvme -v 2 -p 3 -block --nm
[2024-10-24 04:31:07]  INFO Starting cert-csi; ver. 1.5.0
[2024-10-24 04:31:07]  INFO Using EVENT observer type
[2024-10-24 04:31:07]  INFO Using config from /etc/kubernetes/admin.conf
[2024-10-24 04:31:07]  INFO Successfully loaded config. Host: https://XX.XXX.XXX.XX:6443
[2024-10-24 04:31:07]  INFO Created new KubeClient
[2024-10-24 04:31:07]  INFO Running 1 iteration(s)
[2024-10-24 04:31:07]  INFO     *** ITERATION NUMBER 1 ***
[2024-10-24 04:31:07]  INFO Starting VolumeExpansionSuite with powerstore-nvme storage class
[2024-10-24 04:31:07]  INFO Successfully created namespace volume-expansion-suite-0fbb1da6
[2024-10-24 04:31:07]  INFO Using default image: quay.io/centos/centos:latest
[2024-10-24 04:31:07]  INFO Creating 3 pods, each with 2 volumes of size (3Gi)
[2024-10-24 04:31:07]  INFO Waiting for all pods in volume-expansion-suite-0fbb1da6 to be READY
[2024-10-24 04:31:21]  INFO All pods are ready in 14.139498792s
[2024-10-24 04:31:21]  INFO Expanding the size of volumes from 3Gi to 6Gi
[2024-10-24 04:31:21]  INFO Waiting for 'FileSystemResizeSuccessful' event for each pod
[2024-10-24 04:32:41]  INFO Pod pod-prov-test-v4c9z: 'FileSystemResizeSuccessful' event detected
[2024-10-24 04:32:41]  INFO Pod pod-prov-test-4cc7f: 'FileSystemResizeSuccessful' event detected
[2024-10-24 04:32:51]  INFO Pod pod-prov-test-xq4cl: 'FileSystemResizeSuccessful' event detected
[2024-10-24 04:32:51]  INFO 'FileSystemResizeSuccessful' event detected for all pods
[2024-10-24 04:32:51]  INFO Deleting all resources in namespace volume-expansion-suite-0fbb1da6
[2024-10-24 04:33:09]  INFO Namespace volume-expansion-suite-0fbb1da6 was deleted in 18.069329258s
[2024-10-24 04:33:09]  INFO SUCCESS: VolumeExpansionSuite in 2m2.36119528s
[2024-10-24 04:33:09]  INFO Started generating reports...
Collecting metrics
1 / 1 [-----------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% ? p/s[2024-10-24 04:33:09]  INFO Avg time of a run:   104.28s
[2024-10-24 04:33:09]  INFO Avg time of a del:   18.07s
[2024-10-24 04:33:09]  INFO Avg time of all:     122.36s
[2024-10-24 04:33:09]  INFO During this run 100.0% of suites succeeded

@AkshaySainiDell AkshaySainiDell merged commit 2ab294c into main Oct 24, 2024
4 checks passed
@AkshaySainiDell AkshaySainiDell deleted the volumeex_block_test branch October 24, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants