fix error span.finish() call when already called. (#6)

* fix error span.finish() call when already called. * fix error span.finish() call when already called. Remove call to res finish event * Revert "fix error span.finish() call when already called." This reverts commit ff4dc42 * Added support for NodeJS v12 which triggers close event in all requests Co-authored-by: rotem Bloom <[email protected]> Co-authored-by: Dekel Barzilay <[email protected]>
dekelev · Nov 10, 2020 · aa84bfa · aa84bfa
1 parent 84e029d
commit aa84bfa
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/middleware.js b/lib/middleware.js
@@ -40,8 +40,15 @@ module.exports = function (req, res, options = {}) {
     const cookieName = key.replace('uber', 'X').replace(/\b\w/g, l => l.toUpperCase());
     res.setHeader(cookieName, responseHeaders[key]);
   });
+
+  let spanFinished = false;
 
   const finishSpan = () => {
+    if (spanFinished)
+      return;
+
+    spanFinished = true;
+
     if (res.statusCode >= 400) { span.log({ event: 'request_error', message: res.statusMessage }); } else { span.log({ event: 'request_finished' }); }
 
     span.setTag(opentracing.Tags.HTTP_STATUS_CODE, res.statusCode);