Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes #26 #30

Merged
merged 1 commit into from
Dec 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified backend/netfetch
Binary file not shown.
55 changes: 27 additions & 28 deletions backend/pkg/k8s/scanner.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,27 +72,13 @@ func isNetworkError(err error) bool {
func ScanNetworkPolicies(specificNamespace string, returnResult bool, isCLI bool, printScore bool, printMessages bool) (*ScanResult, error) {
var output bytes.Buffer
var namespacesToScan []string
var kubeconfig string

unprotectedPodsCount := 0
scanResult := new(ScanResult)

writer := bufio.NewWriter(&output)
if home := homedir.HomeDir(); home != "" {
kubeconfig = filepath.Join(home, ".kube", "config")
}

config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
if err != nil {
if !kubeconfigExists(kubeconfig) {
fmt.Println("It appears you are not connected to a Kubernetes cluster. Please check your kubeconfig.")
return nil, err
}
fmt.Printf("Error building kubeconfig: %s\n", err)
return nil, err
}

clientset, err := kubernetes.NewForConfig(config)
clientset, err := GetClientset()
if err != nil {
fmt.Printf("Error creating Kubernetes client: %s\n", err)
return nil, err
Expand Down Expand Up @@ -278,17 +264,9 @@ func ScanNetworkPolicies(specificNamespace string, returnResult bool, isCLI bool
// Function to create the implicit default deny if missing
func createAndApplyDefaultDenyPolicy(namespace string) error {
// Initialize Kubernetes client
var kubeconfig string
if home := homedir.HomeDir(); home != "" {
kubeconfig = filepath.Join(home, ".kube", "config")
}
config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
if err != nil {
return err
}
clientset, err := kubernetes.NewForConfig(config)
clientset, err := GetClientset()
if err != nil {
return err
return fmt.Errorf("failed to create Kubernetes client: %v", err)
}

// Define the network policy
Expand All @@ -299,7 +277,7 @@ func createAndApplyDefaultDenyPolicy(namespace string) error {
Namespace: namespace,
},
Spec: networkingv1.NetworkPolicySpec{
PodSelector: metav1.LabelSelector{}, // Selects all pods in the namespace
PodSelector: metav1.LabelSelector{},
PolicyTypes: []networkingv1.PolicyType{
networkingv1.PolicyTypeIngress,
networkingv1.PolicyTypeEgress,
Expand Down Expand Up @@ -410,13 +388,34 @@ func HandleNamespaceListRequest(w http.ResponseWriter, r *http.Request) {
json.NewEncoder(w).Encode(map[string][]string{"namespaces": namespaceList})
}

var isClientInitialized = false

// getClientset creates a new Kubernetes clientset
func GetClientset() (*kubernetes.Clientset, error) {
kubeconfig := filepath.Join(homedir.HomeDir(), ".kube", "config")
var kubeconfig string

if !isClientInitialized {
if kc := os.Getenv("KUBECONFIG"); kc != "" {
kubeconfig = kc
fmt.Println("Using KUBECONFIG from environment:", kubeconfig)
} else {
kubeconfig = filepath.Join(homedir.HomeDir(), ".kube", "config")
fmt.Println("Using default kubeconfig path:", kubeconfig)
}
isClientInitialized = true
} else {
if kc := os.Getenv("KUBECONFIG"); kc != "" {
kubeconfig = kc
} else {
kubeconfig = filepath.Join(homedir.HomeDir(), ".kube", "config")
}
}

config, err := clientcmd.BuildConfigFromFlags("", kubeconfig)
if err != nil {
return nil, err
return nil, fmt.Errorf("failed to build config from path %s: %v", kubeconfig, err)
}

return kubernetes.NewForConfig(config)
}

Expand Down
2 changes: 1 addition & 1 deletion backend/statik/statik.go

Large diffs are not rendered by default.