-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add policy exemptions #165
Conversation
…xemptions controller
…ntial regex failure to slashes.
Ran several options with setting exemptions in the store.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't be able to review for a couple days due to in-person things, but wanted to flag to make sure I review this one as it's going to touch some of the same areas as the identity work.
… run all jest tests more than 1 level deep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is in a great spot overall - couple small comments here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other spot to add explicit {}
back - https://github.com/defenseunicorns/uds-core/blob/feat-exemptions/src/pepr/policies/security.ts#L309-L310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% there, couple small things and then this should be g2g
Updates made based on requested changes.
🤖 I have created a release *beep* *boop* --- ## [0.15.0](v0.14.5...v0.15.0) (2024-03-07) ### Features * add policy exemptions ([#165](#165)) ([196df88](196df88)) ### Miscellaneous * **deps:** update dependency defenseunicorns/uds-common to v0.2.2 ([#232](#232)) ([083ae0c](083ae0c)) * **deps:** update githubactions to de90cc6 ([#215](#215)) ([f79eed0](f79eed0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.15.0](defenseunicorns/uds-core@v0.14.5...v0.15.0) (2024-03-07) ### Features * add policy exemptions ([#165](defenseunicorns/uds-core#165)) ([196df88](defenseunicorns/uds-core@196df88)) ### Miscellaneous * **deps:** update dependency defenseunicorns/uds-common to v0.2.2 ([#232](defenseunicorns/uds-core#232)) ([083ae0c](defenseunicorns/uds-core@083ae0c)) * **deps:** update githubactions to de90cc6 ([#215](defenseunicorns/uds-core#215)) ([f79eed0](defenseunicorns/uds-core@f79eed0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
## Description This PR adds a way for users to register policy exemptions at runtime using the uds-core operator. ## Related Issue Relates to #130 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Micah Nagel <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.15.0](v0.14.5...v0.15.0) (2024-03-07) ### Features * add policy exemptions ([#165](#165)) ([196df88](196df88)) ### Miscellaneous * **deps:** update dependency defenseunicorns/uds-common to v0.2.2 ([#232](#232)) ([083ae0c](083ae0c)) * **deps:** update githubactions to de90cc6 ([#215](#215)) ([f79eed0](f79eed0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
This PR adds a way for users to register policy exemptions at runtime using the uds-core operator.
Related Issue
Relates to #130
Type of change
Checklist before merging