Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address AKS ci flakiness #1238

Merged
merged 16 commits into from
Feb 3, 2025
Merged

fix: address AKS ci flakiness #1238

merged 16 commits into from
Feb 3, 2025

Conversation

noahpb
Copy link
Contributor

@noahpb noahpb commented Jan 29, 2025

Description

Creates 3 worker nodes for the AKS CI User nodepool. Fixes current setup where zero nodes are being added to the pool. Also switches to using API Server VNET integration to address dropped connection issues with the API server during UDS Core install.

Related Issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

  • N/A

Checklist before merging

@noahpb noahpb requested a review from a team as a code owner January 29, 2025 18:47
UnicornChance
UnicornChance previously approved these changes Jan 29, 2025
@noahpb noahpb marked this pull request as draft January 30, 2025 14:02
@noahpb noahpb changed the title fix: create 3 worker nodes (fixes previous value being set to null) fix: address AKS ci flakiness Jan 31, 2025
@noahpb noahpb marked this pull request as ready for review February 1, 2025 02:49
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on CI results and the write up 👍

@noahpb noahpb merged commit 262ba3e into main Feb 3, 2025
17 checks passed
@noahpb noahpb deleted the fix/aks-node-count branch February 3, 2025 17:49
mjnagel pushed a commit that referenced this pull request Feb 4, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.35.0](v0.34.1...v0.35.0)
(2025-02-03)


### Features

* add logic to handle updates to operator config
([#1186](#1186))
([004e8b4](004e8b4))
* optional istio cni ztunnel component
([#1175](#1175))
([e003924](e003924))


### Bug Fixes

* add healthz port to neuvector services
([#1223](#1223))
([ec55729](ec55729))
* add patch for adding nv enforcer readiness probe
([#1239](#1239))
([098ef3d](098ef3d))
* address AKS ci flakiness
([#1238](#1238))
([262ba3e](262ba3e))
* checkpoint ci issue
([#1234](#1234))
([548ff6a](548ff6a))
* denied user permissions policy messaging
([#1227](#1227))
([1ccf4f7](1ccf4f7))
* istio package no longer assumes pepr deployments exist
([#1232](#1232))
([ab11592](ab11592))


### Miscellaneous

* **ci:** disable rds parameter group creation
([#1230](#1230))
([b4cb499](b4cb499))
* **deps:** update authservice to v1.0.4
([#1211](#1211))
([da4d043](da4d043))
* **deps:** update grafana
([#1213](#1213))
([54ddd23](54ddd23))
* **deps:** update pepr
([#1197](#1197))
([652c925](652c925))
* **deps:** update prometheus-stack
([#1189](#1189))
([e02c14c](e02c14c))
* **deps:** update support-deps
([#1204](#1204))
([d477f6a](d477f6a))
* **deps:** update support-deps
([#1243](#1243))
([d4179ae](d4179ae))
* **deps:** update support-deps to v1.50.1
([#1241](#1241))
([6c14208](6c14208))
* **docs:** cleanup diagrams
([#1246](#1246))
([f6bffb9](f6bffb9))
* **main:** release 0.35.0
([#1219](#1219))
([c31c608](c31c608))
* switch registry1 ztunnel to proper source
([#1249](#1249))
([defa586](defa586))
* switch unicorn ztunnel to fips image
([#1240](#1240))
([dd63ac6](dd63ac6))


### Documentation

* add documentation on metrics/dashboards for apps
([#1221](#1221))
([d9062da](d9062da))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants