Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on Zarf #23

Closed
UncleGedd opened this issue Mar 12, 2024 · 1 comment · Fixed by #73
Closed

Remove dependency on Zarf #23

UncleGedd opened this issue Mar 12, 2024 · 1 comment · Fixed by #73
Labels
enhancement ✨ New feature or request

Comments

@UncleGedd
Copy link
Collaborator

Description

Today Maru pulls in Zarf for various action cmds. Remove the dependency on Zarf and migrate actions commands to this repo
@UncleGedd UncleGedd added the enhancement ✨ New feature or request label Mar 12, 2024
@Racer159
Copy link
Contributor

@UncleGedd just to tie things together, let me know what timeline / priority you're working this on, we should squish the things that I am working in this PR to make this clean: zarf-dev/zarf#2276

@Racer159 Racer159 mentioned this issue May 8, 2024
Merged
5 tasks
Racer159 added a commit that referenced this issue May 22, 2024
@Racer159 @ericwyles
refactor!: de-zarfify maru-runner (#73)
635060c 
## Description

This PR removes Zarf as a dependency of Maru, and proposes the following
breaking changes to the library API surface:

1. Creating a simple registration system for `./` prefixed apps
2. Not reaching into os.Env within library code (i.e. when processing
`RUN_<VAR>`)

This also proposes the following feature breaking changes:

1. Drop support for `files`.

## Related Issue

Fixes #23 
Fixes #60

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/maru-runner/blob/main/CONTRIBUTING.md)
followed

---------

Co-authored-by: Eric Wyles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: de-zarfify maru-runner defenseunicorns/maru-runner
2 participants
@Racer159 @UncleGedd