Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculating TADs using sep-score-prefix fails #537

Closed
jakevc opened this issue May 6, 2020 · 3 comments
Closed

Recalculating TADs using sep-score-prefix fails #537

jakevc opened this issue May 6, 2020 · 3 comments

Comments

@jakevc
Copy link
Contributor

jakevc commented May 6, 2020

When attempting to recalculate using --TAD_sep_score_prefix, hicFindTADs fails:

$ hicFindTADs -m ../cool/human.cool --outPrefix human_min10_max60_fdr_01 --TAD_sep_score_prefix human_min10_max60_fdr --delta 0.01 --correctForMultipleTesting fdr --thresholdComparisons 0.01 -p 16
INFO:hicexplorer.hicFindTADs:
Using existing TAD-separation score file: human_min10_max60_fdr_tad_score.bm

Traceback (most recent call last):
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/bin/hicFindTADs", line 7, in <module>
    main()
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/lib/python3.6/site-packages/hicexplorer/hicFindTADs.py", line 1372, in main
    ft.set_matrix(zscore_matrix_file, args.chromosomes)
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/lib/python3.6/site-packages/hicexplorer/hicFindTADs.py", line 406, in set_matrix
    self.hic_ma = hm.hiCMatrix(pMatrix)
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/lib/python3.6/site-packages/hicmatrix/HiCMatrix.py", line 55, in __init__
    self.correction_factors, self.distance_counts = self.matrixFileHandler.load()
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/lib/python3.6/site-packages/hicmatrix/lib/matrixFileHandler.py", line 45, in load
    return self.matrixFile.load()
  File "/home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer/lib/python3.6/site-packages/hicmatrix/lib/h5.py", line 35, in load
    matrix = csr_matrix(tuple([parts['data'], parts['indices'], parts['indptr']]),
KeyError: 'data'

Using hicexplorer in a conda environment with versions:

 packages in environment at /home/groups/hoolock2/u0/jvc/miniconda3/envs/hicexplorer:
hic2cool                  0.7.1                      py_0    bioconda
hicexplorer               3.4.3                      py_0    bioconda
hicmatrix                 12                         py_0    bioconda
@agalitsyna
Copy link

Hi, I think I've encountered a problem that might be related.
I run hicFindTADs on .cool file and do multiple runs (so that prefix remains the same). However, for the second run, when HiCExplorer recognizes the prefix and uses existing files, I got the following error:

hicFindTADs --matrix dataset.10000.cool --outPrefix tmp --correctForMultipleTesting fdr --minDepth 30000 --maxD
epth 1000000 --step 10000 --delta 0.01 -p 20
INFO:numexpr.utils:Note: detected 80 virtual cores but NumExpr set to maximum of 64, check "NUMEXPR_MAX_THREADS" environment variable.
INFO:numexpr.utils:Note: NumExpr detected 80 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 8.
INFO:numexpr.utils:NumExpr defaulting to 8 threads.
INFO:hicexplorer.hicFindTADs:
Found existing TAD-separation score file: tmp_tad_score.bm

INFO:hicexplorer.hicFindTADs:This file will be used

INFO:hicmatrix.lib.h5:No h5 file. Please check parameters concerning the file type!```

@jakevc
Copy link
Contributor Author

jakevc commented May 15, 2020

see #377

@LeilyR LeilyR mentioned this issue May 18, 2020
19 tasks
joachimwolff added a commit that referenced this issue Jun 29, 2020
@joachimwolff
Copy link
Collaborator

Implemented with version 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants