Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hicPlotMatrix --bigwig not at correct position #462

Closed
GinaRe opened this issue Nov 19, 2019 · 3 comments
Closed

hicPlotMatrix --bigwig not at correct position #462

GinaRe opened this issue Nov 19, 2019 · 3 comments
Labels

Comments

@GinaRe
Copy link
Collaborator

GinaRe commented Nov 19, 2019

When I use hicPlotMatrix --bigwig PC1.bw without --clearMaskedBins to plot a Hi-C matrix and its A/B compartment track, the position of the bw track is not correct. This only happens when the start of a chromosome is removed (using hicAdjustMatrix). The bw track in the following plot should start at the start of the matrix.
Dmel_m50_pearsonMatrix_v10.pdf

@LeilyR LeilyR mentioned this issue May 18, 2020
19 tasks
@LeilyR LeilyR added the bug label May 22, 2020
joachimwolff added a commit that referenced this issue Jul 1, 2020
@joachimwolff
Copy link
Collaborator

Implemented with version 3.5.

@GinaRe
Copy link
Collaborator Author

GinaRe commented Jul 28, 2020

I have tested version 3.5. The same problem persists. Here are the examples:

  1. hicPlotMatrix -m Dmel_m50_pearsonMatrix.h5 -o Dmel_m50_pearsonMatrix_v11.pdf --bigwig Dmel_A840_Rep1_Rep2_merge_m50_corrected_adjusted_PCA.bw --chromosomeOrder 2R
  2. hicPlotMatrix -m Dmel_m50_pearsonMatrix.h5 -o Dmel_m50_pearsonMatrix_v12.pdf --bigwig Dmel_A840_Rep1_Rep2_merge_m50_corrected_adjusted_PCA.bw --chromosomeOrder 2R --clearMaskedBins

The second version using --clearMaskedBins shows the correct position of the bw track. I have removed 0-7Mb from the matrix using hicAdjustMatrix.
Dmel_m50_pearsonMatrix_v11.pdf
Dmel_m50_pearsonMatrix_v12.pdf

@LeilyR
Copy link
Collaborator

LeilyR commented Aug 5, 2020

I have tested this, and I generated another error.
envs/HiCExplorer-3.5/lib/python3.7/site-packages/hicexplorer/hicPlotMatrix.py", line 962, in plotBigwig num_bins = int(bigwig_end - region_start) // pResolution ZeroDivisionError: integer division or modulo by zero

LeilyR pushed a commit that referenced this issue Aug 6, 2020
@LeilyR LeilyR mentioned this issue Aug 6, 2020
2 tasks
LeilyR added a commit that referenced this issue Aug 6, 2020
* fixed a bug in hicAdjust remove. the bug was that the bin info was not getting saved to the output matrix file

* small cosmetic change

* removed a print

* fixed #462

* removed a comment

* lint

* fixed the issue with chr vs '' in chromsome names

* fixed start and end regions in getRegion funxtion

* removed some print

Co-authored-by: Leily Rabbani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants