Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Images for running Haystack #85

Merged
merged 4 commits into from
May 4, 2020
Merged

Add Docker Images for running Haystack #85

merged 4 commits into from
May 4, 2020

Conversation

tanaysoni
Copy link
Contributor

This PR adds a docker-compose file for running Haystack on CPU and a shell script to run on GPU.

@tanaysoni tanaysoni requested a review from tholor April 30, 2020 13:52
version: '3'
services:
haystack-api:
image: "deepset/haystack-api-cpu:0.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about naming the image "deepset/haystack-cpu:0.2.0" without the "api"? Is there anything specific for the API in it? We might also re-use it for training / eval ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds good. The CMD for the image is specific to the API, but that can easily be moved to docker-compose.yml and run_docker_gpu.sh.

@tanaysoni tanaysoni merged commit 3d395cd into master May 4, 2020
@tanaysoni tanaysoni deleted the docker branch May 4, 2020 15:28
masci added a commit that referenced this pull request Nov 27, 2023
Implement generic `default_to_dict` and `default_from_dict`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants