Standardize Finder, Readers, and Retriever interfaces #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
Retriever-Reader Interface
meta_data
. This PR introduces aDocument
schema that encapsulates documents and theirmeta_data
. It simplifies the Retriever-Reader pipeline since now Retrievers only need to return a list ofDocument
.Simplify IDs
Document.id
) is now the_id
field from ESexternal_source_id
is added to identify the source file for the case when a large file is split across multiple ES documents.Code Style